Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails for the 'release' task but works for 'build' #39

Open
cernautan opened this issue Mar 13, 2018 · 0 comments · May be fixed by #40
Open

Build fails for the 'release' task but works for 'build' #39

cernautan opened this issue Mar 13, 2018 · 0 comments · May be fixed by #40

Comments

@cernautan
Copy link

Description

On a fresh clone of this project, a 'build' completes successfully while a 'release' fails

Steps to Reproduce

  1. clone this repository
  2. execute yarn to gather all dependencies
  3. execute: ./node_modules/.bin/sense-go build - the command completes successfully
  4. execute: ./node_modules/.bin/sense-go release - the command fails and the log shows:

[15:17:56] uglify:tmp An error occurred. Use -d to show details
[15:17:56] release An error occurred. Use -d to show details

  1. execute: ./node_modules/.bin/sense-go release - - the command fails but shows more information on the error

[15:18:10] uglify:tmp An error occurred. Here are the details:
error { uid: 7,
name: 'uglify:tmp',
branch: false,
error:
{ GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: beautify is not a supported option
File: C:\work\sources\forks\sense-export.tmp\initialproperties.js
at createError (C:\work\sources\forks\sense-export\node_modules\gulp-uglify\lib\create-error.js:6:14)
at apply (C:\work\sources\forks\sense-export\node_modules\lodash_apply.js:16:25)
at wrapper (C:\work\sources\forks\sense-export\node_modules\lodash_createCurry.js:41:12)
at C:\work\sources\forks\sense-export\node_modules\gulp-uglify\lib\minify.js:54:15
at DestroyableTransform._transform (C:\work\sources\forks\sense-export\node_modules\gulp-uglify\composer.js:10:23)
at DestroyableTransform.Transform._read (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_transform.js:159:10)
at DestroyableTransform.Transform._write (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_transform.js:147:83)
at doWrite (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_writable.js:338:64)
at writeOrBuffer (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_writable.js:327:5)
at DestroyableTransform.Writable.write (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_writable.js:264:11)
at DestroyableTransform.ondata (C:\work\sources\forks\sense-export\node_modules\readable-stream\lib_stream_readable.js:541:20)
at emitOne (events.js:116:13)

... - the stack track continues.

Expected behavior

The build should completes successfully for the 'release' task.

Actual behavior

See section 'Steps to reproduce'.

Environment

  • node v8.10.0
  • npm 5.6.0
  • yarn v1.3.2

Operating system

[x ] Windows
[ ] OSX
[ ] Linux

I added this issue for tracking purpose. The fix is to upgrade the sense-go version that is used by this project. I will submit briefly a pull request for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant