Note held in weird situation

[BleuLlama]

U4ia's "U4ic Nightmare" (attached), position 8, pattern 4 holds a note at the end.
u4ic_nightmare_2.mod.zip

Protracker, where he originally composed it, doesn't do it, but every mod player (including mikmod, on which i had tried to fix it) holds that note.

It would appear that the pattern attempts to trigger a new sample (#2) but still has the '300' effect on the line. Which is likely an error by U4ia; but at least shows the behavior difference. ;)

I think it needs basically a case where if the sample is changing that should have priority over the portmanteau/other effects? I'm not sure how your engine works yet. ;D

[steffest]

Hmmm ... there's some Protracker specific behaviour indeed.
I made a small example to single out that part (in attachment)
testeffectnoteswap.mod.zip
These are the same samples then your file.
on channel 1, there the note sequence ends with the sample 2 (and the 300 effect), and the sample is not played on Protracker.
on channel 2, there the same note sequence ends with note 5 (and the 300 effect), and the sample IS played.
My guess is that Protracker still keeps the loop (and finetune) of the previous sample 6, and swaps it on the fly with the audio data of the new sample.
with sample 2 this result in silence, because the loop is on a silent section, on sample 5, it's hearable.
I would have to investigate some more but that's my gutfeeling.
That "on the fly sample swap thing" is related to issue #22 - not so easy to implement in webaudio ...
And I don't even know if it is worth the effort as 100% compatibility is not really THE most important goal.

[BleuLlama]

Fair enough, completely understood. :) 👍