Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo in build summary is not readable on the Dark Theme #275

Closed
rajbos opened this issue Apr 13, 2023 · 4 comments 路 Fixed by #281
Closed

Logo in build summary is not readable on the Dark Theme #275

rajbos opened this issue Apr 13, 2023 · 4 comments 路 Fixed by #281

Comments

@rajbos
Copy link

rajbos commented Apr 13, 2023

"Harden runner" is black, doesn't work that well 馃槃.

image
@varunsh-coder
Copy link
Member

Thanks for reporting this issue @rajbos! I will get it addressed soon.

@varunsh-coder
Copy link
Member

I got the new logo for dark theme. I will add it to this issue.

This is how we can use for different themes
https://www.stefanjudis.com/notes/how-to-define-dark-light-mode-images-in-github-markdown/

We need to update the README and here

harden-runner/src/common.ts

Line 19 in 910b327

.addImage(

@arjundashrath please take this up.

@varunsh-coder
Copy link
Member

HardenRunnerDarkTheme
I am attaching the dark theme logo.

@varunsh-coder varunsh-coder mentioned this issue Apr 19, 2023
Merged
@varunsh-coder
Copy link
Member

@rajbos, this is fixed and released. Please let me know if you still see an issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v2.3.1 step-security/harden-runner
2 participants
@rajbos @varunsh-coder