Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to context.payload.repository #279

Closed
varunsh-coder opened this issue Apr 17, 2023 · 1 comment · Fixed by #281
Closed

Remove reference to context.payload.repository #279

varunsh-coder opened this issue Apr 17, 2023 · 1 comment · Fixed by #281
Labels
bug Something isn't working

Comments

@varunsh-coder
Copy link
Member

We have it here, but it is not being used.

harden-runner/src/setup.ts

Line 53 in 910b327

private: context.payload.repository.private,

In some cases, it causes the pre step to fail if context.payload.repository is undefined. I don't know why it is undefined sometimes.
https://github.com/inspect-js/.github/actions/runs/4725001248/jobs/8382960581
@varunsh-coder varunsh-coder added the bug Something isn't working label Apr 17, 2023
@varunsh-coder
Copy link
Member Author

varunsh-coder commented Apr 17, 2023 •
edited

@arjundashrath please take this up.

@varunsh-coder varunsh-coder mentioned this issue Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release v2.3.1 step-security/harden-runner
1 participant
@varunsh-coder