Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS without Observables #1020

Open
aabrams opened this issue Mar 26, 2024 · 1 comment
Open

NestJS without Observables #1020

aabrams opened this issue Mar 26, 2024 · 1 comment

Comments

@aabrams
Copy link

aabrams commented Mar 26, 2024

I'm using version 1.170 with nestJs=true

I'm seeing gRPC services with Observable, no matter how I configure returnObservable.

I think the correct behavior is to return observable only for stream responses, is there a way to configure it so?

Thanks!

@stephenh
Copy link
Owner

Hi @aabrams , honestly I'm not a NestJS expert or user, but can just point you to this line in the ts-proto source code:

    // Return observable since nestjs client always returns an Observable
    const returns = responseObservable(ctx, methodDesc);

That is from awhile ago, so if the situation has changed (or maybe was never true 🤷 ), and you're willing to submit a PR to fix it, that'd be great! Thanks!

@stephenh stephenh changed the title --ts_proto_opt=nestJs=true forces Observable use NestJS without Observables Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants