Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addNestjsRestParameter incorrectly modifies client signatures #160

Closed
ssilve1989 opened this issue Oct 26, 2020 · 0 comments · May be fixed by #161
Closed

addNestjsRestParameter incorrectly modifies client signatures #160

ssilve1989 opened this issue Oct 26, 2020 · 0 comments · May be fixed by #161

Comments

@ssilve1989
Copy link
Contributor

ssilve1989 commented Oct 26, 2020

When using the addNestjsRestParameter option it also modifies the signature of the client methods, resulting in the following output:

export interface SampleClient {
    log(request: Event, metadata: Metadata, ...rest: any): Observable<Unused>;
}
export interface SampleServiceController {
    log(request: Event, metadata: Metadata, ...rest: any): Promise<Unused> | Observable<Unused> | Unused;
}

The additional rest parameter should not apply to client calls. The way it stands, this signature requires Metadata to be set on all client calls, which is not required by gRPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants