-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proto3 field presence feature #73
Comments
Wow @linarkou sorry for taking awhile to get back to you, but I'd heard not about this. This seems like a huge deal. proto3 missing I'm still reading the impl details, i.e. about the synthetic oneof approach, but, yes, I think its really reasonable for ts-proto to support this "new" :-) |
@linarkou let me know if you're interesting in hacking on this, would be great to have a PR. Otherwise it's a great feature, so I'll get around to hacking on it at some point. |
@stephenh I'm new in typescript, so I think I can't help you, sorry( |
This probably needs protobufjs support. protobufjs/protobuf.js#1406 |
@cliedeman I could be wrong, but fwiw I don't think so. ts-proto calls the lower-level reader/write APIs in protobuf.js's |
@linarkou @cliedeman I've added supported for this in v1.32.0; I haven't updated the readme yet, but you'll have to use the protoc experimental flag mentioned in their docs. Please report any bugs if you try it and find anything wrong. Thanks! |
Hi!
Protobuf released new feature https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md that allows
null
s for primitive types.So there is no need in wrappers.
What about support this?
Also see the implementation docs at https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/implementing_proto3_presence.md
The text was updated successfully, but these errors were encountered: