Support importSuffix with outputTypeRegistry

[adsau59]

I am using this command to generate

protoc --plugin=protoc-gen-ts_proto=".\\node_modules\\.bin\\protoc-gen-ts_proto.cmd" --ts_proto_opt=outputTypeRegistry=true --ts_proto_opt=importSuffix=.js --ts_proto_opt=esModuleInterop=true --proto_path=$pwd\proto\src --ts_proto_out=$pwd\proto\build $pwd\proto\src\messages.proto

in this, outputTypeRegistry=true creates a typeRegistery.ts file which other generated proto ts files tries to import, but as importSuffix=.js is also set, it tries to import typeRegistery.js instead which gives me

Error: Cannot find module './typeRegistry.js'

---

I want to use the outputTypeRegistry, as it does kindof eases my work as i dont have to maintain the list myself... but I also need importSuffix=.js as cocos doesn't work without it

[adsau59]

if it would import typeRegistry and other script which are generated without .js and protobufjs/minimal with .js it would be perfect, how can i do that?

[adsau59]

okay so for now, i removed importSuffix=.js and ran find proto/build -type f -exec sed -i 's/protobufjs\/minimal/protobufjs\/minimal.js/g' {} +

which seems to be working fine for now

[stephenh]

Hi @adsau59 , this is not entirely surprising, as the outputTypeRegistry and importSuffix features were written at different times / by different contributors. If you include more context what specific generated lines were incorrect, this would probably be easy to fix.

We have a test case for import-suffix here, if you wanted to add outputTypeRegistry to it and then reproduce the error in a PR, that'd be great:

https://github.com/stephenh/ts-proto/blob/main/integration/import-suffix/parameters.txt

Thanks!

[adsau59]

Hi @adsau59 , this is not entirely surprising, as the outputTypeRegistry and importSuffix features were written at different times / by different contributors. If you include more context what specific generated lines were incorrect, this would probably be easy to fix.

We have a test case for import-suffix here, if you wanted to add outputTypeRegistry to it and then reproduce the error in a PR, that'd be great:

https://github.com/stephenh/ts-proto/blob/main/integration/import-suffix/parameters.txt

Thanks!

so the issue is that, generated files are .ts files, but they are imported using .js extention due to importSuffix=.js

I am not sure what exactly what you want me to do, but I'd be happy to create a PR

[stephenh]

I am not sure what exactly what you want me to do

Ah yeah; the readme describes in ts-proto here but the basic gist is that parameters.txt is what turns on/off the various opts/flags, and we have a bunch of directories/parameters.txts to test the various combinations of flags.

So we already have an test, in the import-suffix directory, for testing the importSuffix flag, but it doesn't have the outputTypeRegistry flag enabled.

My suggestion was to try enabling the outputTypeRegistry flag for that test, see the readme for how to re-run the codegen with the new flag applied, and then in theory we should see/reproduce a compile error that matches what we're seeing.

If you don't, hopefully you could nudge the import-suffix's parameters.txt / *.proto files around to reproduce the error you're seeing.

[adsau59]

Thanks for the explanation, will try it out and get back to u...

[adsau59]

@stephenh can u assign me the issue pls?