fix: always use Map for int64 keys (#708) #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! |
|
🎉 This PR is included in version 1.156.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
eladhaim
pushed a commit
to eladhaim/ts-proto
that referenced
this pull request
Sep 2, 2023
* fix: always use Map for int64 keys (stephenh#708) * build: change prettier trailingComma to all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes issue #708.
As you suggested in the issue comment, I made the change to always use the Map type for a protobuf map with long keys.
Note that I had to downgrade the Prettier package from 3.0.0 to 2.8.8 (the latest version 2 release) because there is an issue preventing Jest snapshot updating: jestjs/jest#14305.
I also added
"trailingComma": "all"to the .prettierrc file to match the original formatting.Please let me know if there is anything that needs to be changed.