Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mezzanine from Bootstrap 3 to Bootstrap 5 alpha #1966

Closed
wants to merge 0 commits into from

Conversation

hopechan
Copy link

Changes made so far

  • Update bootstrap css and js files

  • Remove jquery files

@hopechan hopechan changed the title Update Mezzanine from Bootstrap3 to Bootstrap5 Update Mezzanine from Bootstrap 3 to Bootstrap 5 alpha Aug 14, 2020
@jerivas jerivas self-requested a review August 15, 2020 17:45
@@ -1,81 +0,0 @@
$(function()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to make sure that any behavior defined in this file is preserved in vanilla JS, as this file is not part of Bootstrap but rather some customizations made by Mezzanine. I've identified the following:

  • CSS tweaks to form inputs (most likely for form.html)
  • Dropdowns fixes to increase the timeout on dropdown hover

@@ -1,18706 +0,0 @@
/*! jQuery UI - v1.12.1 - 2016-09-14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jQuery is still being used in the admin and on the inline editor. As you add or remove files make sure you test the admin (specifically the admin page tree and admin inlines). You will also need to test the frontend editor by login in as admin and using the little "Edit" tags (see screenshot). This feature is documented here: http://mezzanine.jupo.org/docs/inline-editing.html

We definitely want to get rid of jQuery for regular users, but admin users will still need to load it for the inline-editor.

image

@jerivas
Copy link
Collaborator

jerivas commented Aug 15, 2020

@hopechan thank you for contributing this! I see for now you are just removing the jQuery dependencies so I've left a review with some more detail on that

Also, you might be basing your PR on the old Django 2.2 branch. Make sure you pull and reset from upstream/master instead of origin to ensure you get the squashed commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap 4
2 participants