Skip to content
This repository has been archived by the owner on Nov 9, 2018. It is now read-only.

APNS Error Handling #28

Open
andrewkowalik opened this issue Oct 22, 2013 · 3 comments
Open

APNS Error Handling #28

andrewkowalik opened this issue Oct 22, 2013 · 3 comments

Comments

@andrewkowalik
Copy link
Contributor

APNService class | _write_message

Since APNS socket connection is not synchronous should we not be restarting at the device that failed based on the return message from APNS and not at the current device we are iterating over?

I might be misunderstanding how error handling happens when we call send on the APNS connection. It seems to me that since the error will lag behind our processing server side we will be catch the error on the wrong device leading to skipping a number of devices between the one that closed the connection and the one we are currently processing.

@mbargiel
Copy link
Collaborator

The Apple docs describe very well how errors should be handled to have robust error handling. (https://developer.apple.com/library/ios/technotes/tn2265/_index.html#//apple_ref/doc/uid/DTS40010376-CH1-TNTAG44)

@andrewkowalik
Copy link
Contributor Author

Yes its a decent reference.

Unfortunately I do not think it answers my question about how this library handles errors.

@mbargiel
Copy link
Collaborator

Agreed. That's more a reference as to how this library should handle errors. Currently, I think the issue that you raised is valid and should be addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants