add option[:at] to #ping

[kazuooooo]

Hi, I added at option to #ping method.

In default text option, need to write like this to add @ or special command.

notifier.ping "<@john> <@ken> <@smith> <!here> <@tailar> Hi let's go drink tonight!"

message tend to be long and little hard to read

so I added at option it can be written like this.

notifier.ping "Hi let's go drink tonight!", at: [:john, :ken, :smith, :here, :tailer]
# => {text: "<@john> <@ken> <@smith> <!here> <@tailar> Hi let's go drink tonight!"}

thanks,

[kazuooooo]

sorry, I don't know well why travis fails...

[stevenosloan]

This seems like a neat concept that would certainly be useful, could you change it over to be implemented via a middleware? (https://github.com/stevenosloan/slack-notifier#writing-your-own-middleware) if not, no worries -- this test case & implementation should be straightforward enough to move over myself.

[stevenosloan]

It'll make more sense once it's moved to a middleware, but these should be moved to a class constant.

[kazuooooo]

@stevenosloan
Thank you for your review.
OK, I'm going to try moving it to middleware.

[kazuooooo]

@stevenosloan
hi 😄 I moved at option to middle ware.
could you check again?

notifier = Slack::Notifier.new
# it can be set as option
# notifier = Slack::Notifier.new url do
#   middleware :at [:default_at_user]
# end
notifier.ping("Hi let's go drink tonight!", at: [:john, :ken, :smith, :here, :tailer])
# => {text: "<@john> <@ken> <@smith> <!here> <@tailar> Hi let's go drink tonight!"}

[kazuooooo]

I don't still know why travis fails....
Probably, it's not caused of my implementation.
Sorry for that 🤕

[stevenosloan]

Yeah, no worries about those failures -- were coming from ku1ik/rainbow#48 (hoping the suggested fix works).

Thanks for taking the time to reformat that! I'll look at cutting a 2.1.0 release sometime this week.

[kazuooooo]

Thank you so much :) !!
Looking forward next release!!