Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 17.7 Pre-Release as main published version? #391

Open
karlhorky opened this issue Dec 7, 2023 · 3 comments
Open

Release 17.7 Pre-Release as main published version? #391

karlhorky opened this issue Dec 7, 2023 · 3 comments

Comments

@karlhorky
Copy link

karlhorky commented Dec 7, 2023

Hi @stkb, thanks so much for making Rewrap!

What do you think about republishing the 17.7 Pre-Release (from 2022) as the main released version?

It has great features like onSave, which many users would benefit from.

@karlhorky karlhorky changed the title Release Pre-release as main published version? Release Pre-Release as main published version? Dec 7, 2023
@karlhorky karlhorky changed the title Release Pre-Release as main published version? Release 17.7 Pre-Release as main published version? Dec 7, 2023
@lumoe
Copy link

lumoe commented Feb 4, 2024

Using the pre-relase for a while now, especially for the onSave feature.
Looks stable to me, would appreciate releasing it as the main released version as well.

Thank you for your time and work, @stkb

@rdsedmundo
Copy link

The onSave doesn't work well for code comments. I realize it may be challenging to distinguish, but it's quite common to comment a whole block for testing purposes, and it's rewrapping everything as of now.

Before:

await transaction.rollback(
      { status: 'pending' },
      null,
      { transaction: sqlTransaction },
      /*hint*/ true,
      /*immediate*/ false,
      /*delegated*/ true,
    );

Then I comment the whole block using a selection + CMD /:

    // await transaction.rollback(
    //   { status: 'pending' },
    //   null,
    //   { transaction: sqlTransaction },
    //   /*hint*/ true,
    //   /*immediate*/ false,
    //   /*delegated*/ true,
    // );

Upon saving it becomes:

    // await transaction.rollback( { status: 'pending' }, null, { transaction: sqlTransaction }, /*hint*/ true,
    //   /*immediate*/ false, /*delegated*/ true, );

@karlhorky
Copy link
Author

karlhorky commented Feb 13, 2024

@rdsedmundo workaround:

Add Markdown code fences / code block delimiters (three back ticks, like this: ```) above + below the code in your comments (and make sure your commented code doesn't have any uncommented lines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants