Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to complete the unit tests for JSONPointer #590

Closed
stleary opened this issue Mar 6, 2021 · 6 comments
Closed

Need to complete the unit tests for JSONPointer #590

stleary opened this issue Mar 6, 2021 · 6 comments

Comments

@stleary
Copy link
Owner

stleary commented Mar 6, 2021

See the discussion about unit tests in #588. The code has been merged, but should not be released until all of the suggested unit tests have been implemented. Unit tests that are mentioned in the comments and already in place should be refactored if they do not clearly show the expected result in the code. For example, this code:

    @Test
    public void objectPropertyQuery() {
        assertSame(document.get("foo"), query("/foo"));
    }

Could be refactored to:

    @Test
    public void objectPropertyQuery() {
        assertSame(document.get("foo"), query("/foo"));
        assertEquals(query("/foo").toString(), "[\"bar\",\"baz\"]");
    }
@albertotn
Copy link

I'd like to be assigned on this issue, as part of hacktoberfest, if you can label it, thanks!

@johnjaylward
Copy link
Contributor

@albertotn usually we don't assign issues on this project. If you submit a pull request we can review and label that.

@stleary
Copy link
Owner Author

stleary commented Oct 5, 2021

@johnjaylward There might be some Hacktoberfest requirements for the project maintainers. Let me read up on it, and get things set up tonight.

@albertotn Thanks for the offer, I will get the label added.

@stleary
Copy link
Owner Author

stleary commented Oct 6, 2021

Registered with Hacktoberfest, label added, ready to go!

@sreekesh93
Copy link
Contributor

@stleary Completed and raised PR #631

@stleary
Copy link
Owner Author

stleary commented Oct 12, 2021

This issue is being addressed in #631, please continue discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants