Bugfix in JSONObject.Similar()

[eyalb40]

I JSONObject.Similar() you return true\false after comparing a number property. Should only return if false.

Should replace
return isNumberSimilar((Number)valueThis, (Number)valueOther);
with
if (!isNumberSimilar((Number)valueThis, (Number)valueOther))
return false;

[johnjaylward]

Ref:

• https://github.com/stleary/JSON-java/blob/master/src/main/java/org/json/JSONObject.java#L2095
• https://github.com/stleary/JSON-java/blob/master/src/main/java/org/json/JSONArray.java#L1386

I agree, this looks like an oversight in the implementation and a bug

[stleary]

Agreed, good catch @eyalb40, and thanks for the heads-up. Feel free to submit a pull request to fix this, if you want.

[stleary]

Fixed in #613

[johnjaylward]

@stleary, you should also correct the similar in JSONArray