Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically typed time #230

Open
TheZoq2 opened this issue Jun 20, 2020 · 0 comments · May be fixed by #231
Open

Statically typed time #230

TheZoq2 opened this issue Jun 20, 2020 · 0 comments · May be fixed by #231

Comments

@TheZoq2
Copy link
Member

TheZoq2 commented Jun 20, 2020

We have some time_us variables laying around, for example in the blocking i2c implementation

I think it might be better to use the MicroSecond/MilliSecond structs defined in time.rs instead, for reducing the risk of errors, and making clear what the unit is at the call site
@TheZoq2 TheZoq2 linked a pull request Jun 20, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use statically typed time consistently TheZoq2/stm32f1xx-hal
1 participant
@TheZoq2