Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.info.license.name Always Add Word "License" #2523

Open
kentbulza opened this issue Feb 18, 2024 · 8 comments · May be fixed by #2573
Open

$.info.license.name Always Add Word "License" #2523

kentbulza opened this issue Feb 18, 2024 · 8 comments · May be fixed by #2573

Comments

@kentbulza
Copy link

kentbulza commented Feb 18, 2024

Elements adds the word "License" to the end of the string contained in $.info.license.name. This make the assumption that every license is an Apache or MIT or something that would always be followed by the word "License", but it may be that the API uses another convention.

Context

Would like full control over the License string.

Current Behavior

Appends the word "License"

Possible Solution(s)

Simply remove the word "License". If someone wants to append the word "License", they can do so themselves.

@chohmann chohmann added enhancement New feature or request jira help wanted labels Feb 23, 2024
Copy link

This ticket has been labeled jira. A tracking ticket in Stoplight's Jira (STOP-226) has been created.

@kentbulza
Copy link
Author

I want to add some more comment to this. The text actually transforms into a URL to SPDX. This would be the correct behavior for the identifier, which indeed is a SPDX license, but it should not be the behavior for name.

@weyert
Copy link
Contributor

weyert commented Apr 24, 2024

@kentbulza Can you clarify what you are expecting? Some examples of what you expect to happen on the two scenarios identifier and name given then I will see if I solve it for you. Got some time from work to work on Elements issues we have ourselves

@kentbulza
Copy link
Author

kentbulza commented Apr 24, 2024 via email

@weyert
Copy link
Contributor

weyert commented Apr 24, 2024

Don't think we need to query the full name of the SPDX identifier license, right? Just the SPDX identifier itself?

@kentbulza
Copy link
Author

kentbulza commented Apr 24, 2024 via email

@weyert
Copy link
Contributor

weyert commented Apr 24, 2024

Ah that's true. I keep thinking identifier relates to name but it's identifier and/or url :)

@weyert
Copy link
Contributor

weyert commented Apr 25, 2024

@kentbulza Raised a PR, let me know if this is what you imagined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants