Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

satellite/gc: data race TestGarbageCollectionWithCopies and TestGarbageCollectionWithCopiesWithDuplicateMetadata #6796

Open
egonelbre opened this issue Feb 22, 2024 · 2 comments
Open

satellite/gc: data race TestGarbageCollectionWithCopies and TestGarbageCollectionWithCopiesWithDuplicateMetadata #6796

egonelbre opened this issue Feb 22, 2024 · 2 comments
Labels
Flaky

Comments

@egonelbre
Copy link
Member

egonelbre commented Feb 22, 2024 •
edited

https://build.dev.storj.tools/blue/organizations/jenkins/storj/detail/main/4140/pipeline

WARNING: DATA RACE

Read at 0x00c000120fa0 by goroutine 17577:
  github.com/spf13/cobra.(*Command).updateParentsPflags.(*FlagSet).AddFlagSet.func2()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:886 +0x31
  github.com/spf13/pflag.(*FlagSet).VisitAll()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:290 +0x1ed
  github.com/spf13/pflag.(*FlagSet).AddFlagSet()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:885 +0x394
  github.com/spf13/cobra.(*Command).updateParentsPflags()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1869 +0x31e
  github.com/spf13/cobra.(*Command).mergePersistentFlags()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1850 +0x2e
  github.com/spf13/cobra.stripFlags()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:647 +0x64
  github.com/spf13/cobra.(*Command).Find.func1()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:730 +0x6c
  github.com/spf13/cobra.(*Command).Find()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:743 +0xa5
  github.com/spf13/cobra.(*Command).initCompleteCmd()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/completions.go:255 +0x444
  github.com/spf13/cobra.(*Command).ExecuteC()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1084 +0x295
  github.com/spf13/cobra.(*Command).Execute()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039 +0xd7
  github.com/spf13/cobra.(*Command).ExecuteContext()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1032 +0xd2
  storj.io/storj/cmd/storagenode/internalcmd.(*LazyFilewalkerCmd).Run()
      /tmp/workspace/storj_main/cmd/storagenode/internalcmd/cmd_lazy_filewalker.go:72 +0x25
  storj.io/storj/cmd/storagenode/internalcmd.(*LazyFilewalkerCmd).Wait()
      /tmp/workspace/storj_main/cmd/storagenode/internalcmd/cmd_lazy_filewalker.go:84 +0x12
  storj.io/storj/storagenode/pieces/lazyfilewalker.(*process).run()
      /tmp/workspace/storj_main/storagenode/pieces/lazyfilewalker/process.go:76 +0xc9a
  storj.io/storj/storagenode/pieces/lazyfilewalker.(*Supervisor).WalkSatellitePiecesToTrash()
      /tmp/workspace/storj_main/storagenode/pieces/lazyfilewalker/supervisor.go:130 +0x811
  storj.io/storj/storagenode/pieces.(*Store).SatellitePiecesToTrash()
      /tmp/workspace/storj_main/storagenode/pieces/store.go:556 +0x36a
  storj.io/storj/storagenode/retain.(*Service).retainPieces()
      /tmp/workspace/storj_main/storagenode/retain/retain.go:325 +0xc88
  storj.io/storj/storagenode/retain.(*Service).Run.func2()
      /tmp/workspace/storj_main/storagenode/retain/retain.go:221 +0x3f6
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /go/pkg/mod/golang.org/x/sync@v0.5.0/errgroup/errgroup.go:75 +0x91

Previous write at 0x00c000120fa0 by goroutine 14882:
  github.com/spf13/pflag.(*FlagSet).AddFlag()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:854 +0x153
  github.com/spf13/cobra.(*Command).updateParentsPflags.(*FlagSet).AddFlagSet.func2()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:887 +0x5e
  github.com/spf13/pflag.(*FlagSet).VisitAll()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:290 +0x1ed
  github.com/spf13/pflag.(*FlagSet).AddFlagSet()
      /go/pkg/mod/github.com/spf13/pflag@v1.0.5/flag.go:885 +0x394
  github.com/spf13/cobra.(*Command).updateParentsPflags()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1869 +0x31e
  github.com/spf13/cobra.(*Command).mergePersistentFlags()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1850 +0x2e
  github.com/spf13/cobra.stripFlags()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:647 +0x64
  github.com/spf13/cobra.(*Command).Find.func1()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:730 +0x6c
  github.com/spf13/cobra.(*Command).Find()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:743 +0xa5
  github.com/spf13/cobra.(*Command).initCompleteCmd()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/completions.go:255 +0x444
  github.com/spf13/cobra.(*Command).ExecuteC()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1084 +0x295
  github.com/spf13/cobra.(*Command).Execute()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039 +0xd7
  github.com/spf13/cobra.(*Command).ExecuteContext()
      /go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1032 +0xd2
  storj.io/storj/cmd/storagenode/internalcmd.(*LazyFilewalkerCmd).Run()
      /tmp/workspace/storj_main/cmd/storagenode/internalcmd/cmd_lazy_filewalker.go:72 +0x25
  storj.io/storj/cmd/storagenode/internalcmd.(*LazyFilewalkerCmd).Wait()
      /tmp/workspace/storj_main/cmd/storagenode/internalcmd/cmd_lazy_filewalker.go:84 +0x12
  storj.io/storj/storagenode/pieces/lazyfilewalker.(*process).run()
      /tmp/workspace/storj_main/storagenode/pieces/lazyfilewalker/process.go:76 +0xc9a
  storj.io/storj/storagenode/pieces/lazyfilewalker.(*Supervisor).WalkAndComputeSpaceUsedBySatellite()
      /tmp/workspace/storj_main/storagenode/pieces/lazyfilewalker/supervisor.go:105 +0x5a9
  storj.io/storj/storagenode/pieces.(*Store).SpaceUsedTotalAndBySatellite()
      /tmp/workspace/storj_main/storagenode/pieces/store.go:718 +0x745
  storj.io/storj/satellite/gc_test.TestGarbageCollectionWithCopiesWithDuplicateMetadata.func1.1()
      /tmp/workspace/storj_main/satellite/gc/gc_test.go:330 +0xfb
  storj.io/storj/satellite/gc_test.TestGarbageCollectionWithCopiesWithDuplicateMetadata.func1()
      /tmp/workspace/storj_main/satellite/gc/gc_test.go:364 +0xa78
  storj.io/storj/private/testplanet.Run.func1.1()
      /tmp/workspace/storj_main/private/testplanet/run.go:83 +0xe22
  storj.io/storj/private/testmonkit.RunWith()
      /tmp/workspace/storj_main/private/testmonkit/run.go:49 +0x271
  storj.io/storj/private/testmonkit.Run()
      /tmp/workspace/storj_main/private/testmonkit/run.go:43 +0xe4
  storj.io/storj/private/testplanet.Run.func1()
      /tmp/workspace/storj_main/private/testplanet/run.go:51 +0x43d
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1742 +0x44
@egonelbre
Copy link
Member Author

Also here https://build.dev.storj.tools/blue/organizations/jenkins/storj/detail/main/4142/pipeline

@egonelbre
Copy link
Member Author

Quite possibly related spf13/cobra#2109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egonelbre