Reset query params to the initial params when un-mounting. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unmounting our Story, we take the `initialSearch` (the initial `location.search`) and set `location.search` to the original value. This does not maintain any query params added in the meantime, eg. if some other Storybook addon modifies the query parameters.
Open
|
@kylorhall would you like maintainer right to this package? |
|
Hey @ndelangen unfortunately my new role does not use Storybook very much and not this use-case for certain; I wouldn't have any need or ability to maintain this now. I'm happy to direct someone from my prior organization if you were looking, see if they're keen—if they use this workaround I built or not. |
|
Ok, I'll close this PR for now, until there's someone interested in this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered the same issue as #1 and ended up fixing it locally in our own decorator–no longer using this addon–but I might as well push it upstream to this addon. Further basis in that issue and this comment. Should fix #1.
When unmounting our Story, this takes the
initialSearch(the initiallocation.search) and setlocation.searchto the original value.initialSearch.currentis from the very first render and never updated.Quick video to visualize the Storybook file changes:
https://www.loom.com/share/bc19e586965f45a7b9b17b865b7e79ed