Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Update peer dependencies for Vite 4 #545

Merged
merged 5 commits into from Jan 16, 2023
Merged

Breaking: Update peer dependencies for Vite 4 #545

merged 5 commits into from Jan 16, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jan 16, 2023

Fixes #526

This updates the peer dependencies for vite and vite plugins, and also updates @joshwooding/vite-plugin-react-docgen-typescript to a version that makes TypeScript an optional dependency, to avoid peer dependency warnings for non-typescript projects.

Finally, I added a bit of a script to run yarn install in each of the example projects because I got really tired of doing that manually. ;)

FWIW, this will require a bump of this project to 0.3.0 when released. We did something similar for 0.1 to 0.2, without much trouble.

@IanVS IanVS merged commit 1607b74 into main Jan 16, 2023
@IanVS IanVS deleted the vite-4 branch January 16, 2023 20:08
@sfe-efficy
Copy link

Hi!

It's missing to update the dependency @vitejs/plugin-react to v3.0 or higher.
Current version is using vite 3.

npm WARN
npm WARN Could not resolve dependency:
npm WARN peer vite@"^3.0.0" from @vitejs/plugin-react@2.2.0
npm WARN node_modules/@vitejs/plugin-react
npm WARN   @vitejs/plugin-react@"^2.0.0" from @storybook/builder-vite@0.3.0
npm WARN   node_modules/@storybook/builder-vite
npm WARN
npm WARN Conflicting peer dependency: vite@3.2.5
npm WARN node_modules/vite
npm WARN   peer vite@"^3.0.0" from @vitejs/plugin-react@2.2.0
npm WARN   node_modules/@vitejs/plugin-react
npm WARN     @vitejs/plugin-react@"^2.0.0" from @storybook/builder-vite@0.3.0
npm WARN     node_modules/@storybook/builder-vite

@IanVS
Copy link
Member Author

IanVS commented Jan 18, 2023

Hi @sfe-efficy, this was a breaking change that requires Vite 4. If you are using Vite 3, you'll need to install @storybook/builder-vite@0.2.x.

@sfe-efficy
Copy link

I opened an issue, I guess it's better
#547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error with using package (vite4) | Vue
3 participants