From 321ecb92638f341c7b3060ee7b97d16ff8cb3277 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABtan=20Maisse?= Date: Sat, 18 Jan 2020 08:29:32 +0100 Subject: [PATCH 1/2] docs: add a section about external puppeteer in MIGRATION.md --- MIGRATION.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/MIGRATION.md b/MIGRATION.md index 96df607e4b3a..c2cc89444c23 100644 --- a/MIGRATION.md +++ b/MIGRATION.md @@ -9,6 +9,7 @@ - [Deprecate displayName parameter](#deprecate-displayname-parameter) - [Unified docs preset](#unified-docs-preset) - [Simplified hierarchy separators](#simplified-hierarchy-separators) + - [Addon StoryShots Puppeteer uses external puppeteer](#addon-storyshots-puppeteer-uses-external-puppeteer) - [From version 5.1.x to 5.2.x](#from-version-51x-to-52x) - [Source-loader](#source-loader) - [Default viewports](#default-viewports) @@ -220,6 +221,17 @@ addParameters({ NOTE: it is no longer possible to have some stories with roots and others without. If you want to keep the old behavior, simply add a root called "Others" to all your previously unrooted stories. +### Addon StoryShots Puppeteer uses external puppeteer + +To give you more control on the Chrome version used when running StoryShots Puppeteer, `puppeteer` is no more included in the addon dependencies. So you can now pick the version of `puppeteer` you want and set it in your project. + +If you want the latest version available just run: +```sh +yarn add puppeteer --dev +OR +npm install puppeteer --save-dev +``` + ## From version 5.1.x to 5.2.x ### Source-loader From 792064b321d59981cefcfaf376fe8b17f34e3f43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABtan=20Maisse?= Date: Sat, 18 Jan 2020 08:34:36 +0100 Subject: [PATCH 2/2] docs(storyshot-puppeteer): add a warning to emphasize the fact that as of SB 5.3 puppeteer must be added to the project dep directly --- addons/storyshots/storyshots-puppeteer/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/storyshots/storyshots-puppeteer/README.md b/addons/storyshots/storyshots-puppeteer/README.md index 718c0c012435..cb4feceddb20 100644 --- a/addons/storyshots/storyshots-puppeteer/README.md +++ b/addons/storyshots/storyshots-puppeteer/README.md @@ -8,9 +8,11 @@ Add the following modules into your app. npm install @storybook/addon-storyshots-puppeteer puppeteer --save-dev ``` +⚠️ As of Storybook 5.3 `puppeteer` is no more included in addon dependencies and must be added to your project directly. + ## Configure Storyshots for Puppeteeer tests -/\*\ **React-native** is **not supported** by this test function. +⚠️ **React-native** is **not supported** by this test function. When willing to run Puppeteer tests for your stories, you have two options: