From 85d5ce96cc1435c0d3d531d728a347a374c14974 Mon Sep 17 00:00:00 2001 From: Kai Roeder Date: Sun, 2 Feb 2020 01:13:47 +0100 Subject: [PATCH 1/2] Angular: add emitDecoratorMetadata true as default This fixes dependency injection error SomeComponent(?, ?) --- app/angular/src/server/ts_config.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/angular/src/server/ts_config.ts b/app/angular/src/server/ts_config.ts index 2613f61db337..6451fa49a9f9 100644 --- a/app/angular/src/server/ts_config.ts +++ b/app/angular/src/server/ts_config.ts @@ -14,6 +14,9 @@ export default function(configDir: string) { const configFilePath = resolveTsConfig(path.resolve(configDir, 'tsconfig.json')); return { transpileOnly: true, + compilerOptions: { + emitDecoratorMetadata: true, + }, configFile: configFilePath || undefined, }; } From 6cba51fa3b1868474b2644746c2522bcaa143a2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kai=20R=C3=B6der?= Date: Mon, 3 Feb 2020 15:49:24 +0100 Subject: [PATCH 2/2] chore(app/angular): update ts config test to match the new default config --- app/angular/src/server/__tests__/ts_config.test.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/angular/src/server/__tests__/ts_config.test.ts b/app/angular/src/server/__tests__/ts_config.test.ts index 046001787ad8..1b84a549f06d 100644 --- a/app/angular/src/server/__tests__/ts_config.test.ts +++ b/app/angular/src/server/__tests__/ts_config.test.ts @@ -20,6 +20,9 @@ describe('ts_config', () => { expect(config).toEqual({ transpileOnly: true, + compilerOptions: { + emitDecoratorMetadata: true, + }, configFile: 'tsconfig.json', }); }); @@ -31,6 +34,9 @@ describe('ts_config', () => { expect(config).toEqual({ transpileOnly: true, + compilerOptions: { + emitDecoratorMetadata: true, + }, }); }); });