Upgrading to React 17 on app level breaks UI

[Hypnosphi]

Here's the repro: https://github.com/Hypnosphi/test-storybook-react-17

Error I get is:

react.development.js:1431 Uncaught Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.
    at resolveDispatcher (react.development.js:1431)
    at Object.useContext (react.development.js:1439)
    at useTheme (emotion-theming.browser.esm.js:112)
    at useMenu (vendors~main.619dfba2fee0a3e45bd3.bundle.js:25841)
    at Object.mapper [as current] (vendors~main.619dfba2fee0a3e45bd3.bundle.js:26274)
    at ManagerConsumer (vendors~main.619dfba2fee0a3e45bd3.bundle.js:1484)
    at renderWithHooks (vendors~main.619dfba2fee0a3e45bd3.bundle.js:42664)
    at mountIndeterminateComponent (vendors~main.619dfba2fee0a3e45bd3.bundle.js:45343)
    at beginWork (vendors~main.619dfba2fee0a3e45bd3.bundle.js:46457)
    at HTMLUnknownElement.callCallback (vendors~main.619dfba2fee0a3e45bd3.bundle.js:28049)

Brief debugging showed that useTheme imports React from DLL while the rest of manager UI imports it from node_modules/@storybook/ui/node_modules/react

[shilman]

See: fa3a0f1#r42051265

[Hypnosphi]

@shilman it turned out not to be the actual reason, but is worth fixing anyway

[molebox]

See: fa3a0f1#r42051265

hey @shilman I may have missed a release, has this been fixed already? Just wondering as im in the process of drawing up a proposal to introduce storybook into our workflow and the docs keep on failing due to this hook violation error.

[shilman]

@molebox not AFAIK. @Hypnosphi any ideas here?

[Hypnosphi]

Remove react from DLL?

[shilman]

I'm hoping we can get rid of the DLLs entirely in 6.1. Fingers crossed 🤞

[molebox]

I just updated to 6.1.0-alpha.10 and im am now seeing this on every canvas and the docs page doesnt work at all.

[shilman]

@molebox Did you try removing node_modules and/or lockfiles and reinstalling? Also did you try running with --no-dll?

[Hypnosphi]

Same with 16.14.0 + new JSX transform. --no-dll does help

[magic-akari]

--no-dll works with React 17 as well.

[GrossDesignCo]

+1, --no-dll worked for me with React 17 as well

[bcomnes]

Thanks @dburles we're trying to get it back into latest now 😅

Any plans to also increase the react-dom range to support 17?

Edit, looks like there are issues with npm 7 + storybook as well.

[shilman]

Fixed in #12972 / 6.1-beta. Closing.

npx sb@next upgrade --prerelease

[lailsonbm]

Thanks, @shilman!

[thany]

Having this problem as well. I can't upgrade to a nonstable version. Can you backport the fix into 6.0 please?

Also I'm on React 16 and --no-dll doesn't fix anything.

[shilman]

@thany unfortunately we can't backport it easily. instead we're expediting the 6.1 stable release, due in a week or so.

[NeOMakinG]

Hello,

Is this supposed to work ? https://github.com/PrestaShop/prestashop-ui-kit/pull/108/files#diff-0c3746c19bb935bd629052ce8bafe30b5685b04ddf4c879ad49913c31ce59abcR1-R19

I've the same issue while trying to use a useEffect hook inside a mdx story (as I need to execute some JS after a component story is loaded, to make it work properly everytime you'r going to a story through the menu)

I was waiting for the version 6.1 to test if it works, but it looks like it doesn't :(

Maybe I'm not using it properly

[matthias-ccri]

I was able to get this working on react 17 by turning off the new JSX transform.

In the tsconfig

-   "jsx": "react-jsx",
+   "jsx": "react",

And add import * as React from 'react'; in all JSX files as needed. After that, you can wipe the tears off your keyboard 🙍‍♂️