Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Support Angular Ivy rendering of multiple stories on a page #15017

Closed
2 tasks
shilman opened this issue May 24, 2021 · 3 comments
Closed
2 tasks

Comments

@shilman
Copy link
Member

shilman commented May 24, 2021

Currently, Storybook's Angular Ivy support (via https://github.com/storybookjs/addon-angular-ivy) requires that each story be fully rendered before a new story can be rendered.

In Canvas mode it's not an issue because we are only rendering one story at a time. In Docs mode, we are rendering N stories on a page, and Ivy crashes.

To support Ivy in docs mode:

  • Create a wrapper component that's returned by Angular's prepareForInline
  • Each wrapper participates in a global queue. When a it's a component's turn to render, it renders, otherwise, it perform's a no-op

Making this up, so we will probably need @ThibaudAV 's guidance to make this work.

@shilman shilman changed the title Addon-docs: Support Angular Ivy rendering in addon-docs Addon-docs: Support Angular Ivy rendering of multiple stories on a page May 24, 2021
@ThibaudAV
Copy link
Contributor

I think I have a solution from this pr #14911
but still need time to finish and clean the code

@ThibaudAV
Copy link
Contributor

done : #15002

@shilman
Copy link
Member Author

shilman commented Jun 15, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if this is still relevant in SB 7.x.

@shilman shilman closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants