New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Negating globs stopped working in ^6.4.0 #16964
Comments
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
I'd be happy to look into this but I don't know where to start |
Thanks @ciclentfort, I am looking into this alongside some other glob related issues. Will circle back round once I have the big picture sorted out. |
Ok, it was a pretty simple fix to all three issues at once: #17252. Appreciate the offer of help though! |
Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.19 containing PR #17252 that references this issue. Upgrade today to the
Closing this issue. Please re-open if you think there's still more to do. |
Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.14 containing PR #17252 that references this issue. Upgrade today to the
|
@tmeasday I tried with storybook |
I think the issue might be that my glob pattern doesn't include a I think there should be a check for Alternatively, the call to |
Oh, I see. Sorry I thought your use case had fitted my examples, but I suppose it didn't! I think your suggestion to move |
# Summary: Support negated globs like `../!(negation)/*.stories.mdx` in storybook config. **Related issues:** Closes storybookjs#16964
Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.24 containing PR #17328 that references this issue. Upgrade today to the
|
Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.15 containing PR #17328 that references this issue. Upgrade today to the
|
Describe the bug
Using
!(breaks)
to negate matching stopped working with storybook 6.4.0 (still present in 6.5.0-alpha.3). This still worked in 6.3.12.According to picomatch this should be supported
Storybook will throw an error during both
start-storybook
andbuild-storybook
.Attached a log of the output of
build-storybook
.To Reproduce
See https://github.com/ciclentfort/storybook-negate-match/tree/next for a reproduction against 6.5.0-alpha.3 (build will fail)
See https://github.com/ciclentfort/storybook-negate-match/tree/6.3.12 for a reproduction against 6.3.12 (build works)
System
I also tested this against node 16.11.0, errors are still the same.
The text was updated successfully, but these errors were encountered: