Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header and in-page links broken #17035

Closed
andrewplummer opened this issue Dec 18, 2021 · 1 comment
Closed

Header and in-page links broken #17035

andrewplummer opened this issue Dec 18, 2021 · 1 comment

Comments

@andrewplummer
Copy link

andrewplummer commented Dec 18, 2021

In the latest version of Storybook (React) out of the box header links are broken. They will remove the path from the full url and link just the hash which breaks the page and seems to override browser default behavior:

storybook-bug.mp4

Additionally linking directly to headers is also broken in MDX:

import { Meta } from '@storybook/addon-docs';

<Meta title="Test" />

Try to link to [example](#example).

## Example

Probably this is the same issue.

Environment Info:

  System:
    OS: macOS 12.1
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 16.13.0 - ~/.volta/tools/image/node/16.13.0/bin/node
    Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
    npm: 8.1.0 - ~/.volta/tools/image/node/16.13.0/bin/npm
  Browsers:
    Chrome: 96.0.4664.110
    Firefox: 95.0
    Safari: 15.2
  npmPackages:
    @storybook/addon-actions: ^6.4.9 => 6.4.9
    @storybook/addon-essentials: ^6.4.9 => 6.4.9
    @storybook/addon-links: ^6.4.9 => 6.4.9
    @storybook/react: ^6.4.9 => 6.4.9
@shilman
Copy link
Member

shilman commented Dec 23, 2021

closing as dupe to #16918

@shilman shilman closed this as completed Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants