Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding a keyboard shortcut for Remount component button in toolbar #18669

Closed
akilansengottaiyan opened this issue Jul 9, 2022 · 9 comments · Fixed by #21401
Closed

Binding a keyboard shortcut for Remount component button in toolbar #18669

akilansengottaiyan opened this issue Jul 9, 2022 · 9 comments · Fixed by #21401

Comments

@akilansengottaiyan
Copy link

akilansengottaiyan commented Jul 9, 2022

Is your feature request related to a problem? Please describe
Having a button for Remounting a component is super useful. But for such a super useful feature, having no keyboard shortcut bound to it makes the developer life difficult.

Describe the solution you'd like
As we have shortcuts for different actions in toolbar, we could also assign a shortcut to it possibly (alt + R)

Describe alternatives you've considered
None.

Are you able to assist to bring the feature to reality?
yes, I can.

Additional context
Button in the toolbar titled Remount component
Attaching a screenshot for more clarity.
Screenshot 2022-07-09 at 3 26 15 PM
I am talking about the button highlighted in the screenshot

@akilansengottaiyan
Copy link
Author

@ndelangen @shilman Kindly take a look and let me know if I could proceed to raise a PR.

@akilansengottaiyan
Copy link
Author

@ndelangen @shilman In case if you missed it.

@MichaelAllenWarner
Copy link

Yes, a keyboard shortcut for remount would be great!

@ndelangen
Copy link
Member

I marked this as "good first issue". If someone would like to work on this, I'd be happy to help get them started!

@Roel-t
Copy link
Contributor

Roel-t commented Feb 1, 2023

I would like to give it a shot! Looked over through a bit at how other shortcuts are done, but if I get block or need your help I will reach out to you through discord.

@ndelangen
Copy link
Member

Awesome! thanks!

@shilman
Copy link
Member

shilman commented Apr 12, 2023

Ta-da!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.3 containing PR #21401 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

@shilman
Copy link
Member

shilman commented Apr 12, 2023

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.2 containing PR #21401 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@shilman
Copy link
Member

shilman commented Apr 24, 2023

Ooh-la-la!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.7 containing PR #21401 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants