-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Investigate Typescript 5.0 #21276
Comments
Probably yes to both. By the time a dependency reaches RC, we probably want to make sure it's green all the way up until the release. We can adjust this if it becomes too noisy. Prior to RC, we should probably either remove that test from our CI, or treat it like a community framework, where we want to know when it fails, but we shouldn't block anything when it fails. |
Is TS 5.0 support intended to only be available in storybook@7? |
@wegry Currently, yes. Only critical security fixes are patched back to 6.5. It does not mean, though, that SB 6.5 does not work with TS 5.0. We just don't guarantee it. |
Just upgraded to TS 5.0.2, and storybook fails on startup in the Error: TypeError: typescript_1.default.createIdentifier is not a function
at setDisplayName (/packages/web/node_modules/@storybook/react/node_modules/@storybook/react-docgen-typescript-plugin/dist/generateDocgenCodeBlock.js:37:186)
at /packages/web/node_modules/@storybook/react/node_modules/@storybook/react-docgen-typescript-plugin/dist/generateDocgenCodeBlock.js:201:34 |
@pachuka I'm also seeing that with storybook 6.5.16 & ts 5.0.2 On the plus side, it works ok for me with storybook 7.0.0-rc.3 & ts 5.0.2 |
Yep I figured it would be fine with storybook 7, but I'd like to upgrade to that after RC/beta is complete, just wanted to point out that if folks wanted it working on 6.5.x probably need a patch for it. |
@vanessayuenn I think there's nothing to do here before GA. I chatted with @valentinpalkovic and identified though there are some possible incompatibilities, users have a few options:
This isn't blocking GA IMHO. |
@ndelangen thanks for the investigation! Good to know this isn't GA-blocking, but is there anything else to be done post-GA? For now, we can update the documentation with the potential incompatibilities you mentioned. |
Long term, we'll want to:
|
closing with followup tasks in #21792 |
Is your feature request related to a problem? Please describe
Typescript 5.0 release is around the corner (March 14th), and the 5.0 RC is available on February 28th. We should make sure that Storybook works with Typescript 5.0.
Describe the solution you'd like
We should set up an internal sandbox that runs Typescript 5.0 prerelease version to avoid unpleasant surprises on the release date.
Questions:
Work items
Describe alternatives you've considered
No response
Are you able to assist to bring the feature to reality?
yes, I can
Additional context
No response
The text was updated successfully, but these errors were encountered: