Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: An additional outline border is displayed in docs mode #21328

Closed
yannbf opened this issue Mar 1, 2023 · 2 comments · Fixed by #21773
Closed

[Bug]: An additional outline border is displayed in docs mode #21328

yannbf opened this issue Mar 1, 2023 · 2 comments · Fixed by #21773

Comments

@yannbf
Copy link
Member

yannbf commented Mar 1, 2023

Describe the bug

Reported by @kbrandwijk (Thank you!)

When seeing a story in canvas, the Outline addon functionality is correct:
image

But when seeing in a docs entry, it outlines more elements that it should not, such as the "show code" button and the story wrapper:
image

The addon should only highlight the child elements of the story wrapper (e.g. <div id="story--components-category--default--primary-inner" data-name="Default">) in docs mode.

To Reproduce

  • Run Storybook 7 with addon-essentials
  • Open a story in docs mode
  • Enable outline (press O on keyboard)

System

No response

Additional context

No response

@shilman
Copy link
Member

shilman commented May 10, 2023

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.15 containing PR #21773 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@shilman
Copy link
Member

shilman commented May 12, 2023

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.11 containing PR #21773 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants