Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Docs: Rendering story breaks when browsing away #21381

Closed
riovir opened this issue Mar 3, 2023 · 2 comments
Closed

[Bug]: Docs: Rendering story breaks when browsing away #21381

riovir opened this issue Mar 3, 2023 · 2 comments

Comments

@riovir
Copy link

riovir commented Mar 3, 2023

Describe the bug

Since the v7.0.0.beta-58 added a setTimeout(() => cleanup(), 0) to the Vue stories shown in the docs are broken when navigating to another docs page. There's a quick blinking effect that can be barely seen:

  • the story renders
  • then disappears

My suspicion is that the cleanup's delay causes the new story to be wiped away.

To Reproduce

Take a basic Vue 3 Storybook (Vite, Webpack doesn't matter), and add two components with docs. Upon navigating from one docs page to the other, the Docs page base story example blinks out of existence.

System

No response

Additional context

This issue is related to #20731
Undoing the setTimeout (essentially backing the previous PR out) fixes this particular issue.

@tmeasday
Copy link
Member

I think this was fixed by #21476 -- @riovir have you tried v7.0.0-beta.63 or later?

@riovir
Copy link
Author

riovir commented Mar 28, 2023

Yes, the latest Release Candidate (RC.8) fixed this issue. I consider it closed on my part, thank you, @shilman.

@tmeasday tmeasday closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants