Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Composition - version switcher doesn't close, no visual feedback #21505

Closed
ndelangen opened this issue Mar 9, 2023 · 3 comments · Fixed by #21621
Closed

[Bug]: Composition - version switcher doesn't close, no visual feedback #21505

ndelangen opened this issue Mar 9, 2023 · 3 comments · Fixed by #21621
Assignees
@ndelangen
Labels
bug composition

Comments

@ndelangen
Copy link
Member

ndelangen commented Mar 9, 2023 •
edited

Related: #21534
Related: #5593

Describe the bug

The version picker works, but is slow. it does not give feedback, it doesn't close

To Reproduce

  • Add the design system as a ref to code/ui/.storybook/main.ts
  • Switch to a different version using the dropdown

System

No response

Additional context

No response
@ndelangen
Copy link
Member Author

@valentinpalkovic do you think your PR #21589 will fix this issue as well?

@valentinpalkovic
Copy link
Contributor

My PR just fixes an issue of not closing the tooltip, if the user clicks into the iframe area

@ndelangen ndelangen mentioned this issue Mar 15, 2023
Merged
@shilman
Copy link
Member

shilman commented Mar 22, 2023

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.6 containing PR #21621 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
bug composition
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug: version switcher of compositions storybookjs/storybook
3 participants
@shilman @ndelangen @valentinpalkovic