Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: IconButton should be in active state when corresponding menu is open #21665

Closed
pratikkarad opened this issue Mar 18, 2023 · 3 comments · Fixed by #21666
Closed

[Bug]: IconButton should be in active state when corresponding menu is open #21665

pratikkarad opened this issue Mar 18, 2023 · 3 comments · Fixed by #21666
Assignees
@pratikkarad
Labels
bug ui

Comments

@pratikkarad
Copy link
Contributor

Describe the bug

Right now, the button reverts to a resting state when the corresponding menu is open making it hard to distinguish what the menu correlates to.

image

To Reproduce

No response

System

No response

Additional context

Recently, a similar issue #21463 got closed but this one got skipped in that.
@pratikkarad
Copy link
Contributor Author

Let me take this home. Please assign it to me.

@pratikkarad pratikkarad mentioned this issue Mar 18, 2023
Merged
5 tasks
@shilman shilman added ui and removed needs triage labels Mar 19, 2023
@pratikkarad
Copy link
Contributor Author

Hi @shilman, I have already created PR. PTAL, Thanks! 😄

@shilman
Copy link
Member

shilman commented Mar 22, 2023

Whoopee!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-rc.6 containing PR #21666 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratikkarad pratikkarad

Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): active state for iconbutton pratikkarad/storybook
2 participants
@shilman @pratikkarad