Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The docs page does not update correctly when changing controls #21894

Closed
techmind-git opened this issue Apr 3, 2023 · 2 comments · Fixed by #21944
Closed

[Bug]: The docs page does not update correctly when changing controls #21894

techmind-git opened this issue Apr 3, 2023 · 2 comments · Fixed by #21944

Comments

@techmind-git
Copy link

Describe the bug

The (auto)docs-page is not updating when changing the value of a prop (like toggle false/true state for a component). The main component on docs-page will update, but in the stories overview part all components disappear. On the individual story-pages the components work fine.

To Reproduce

I was able to reproduce on someone else's storybook: https://geromegrignon.github.io/angular-material-storybook/?path=/docs/usecases-progress-indicators--docs Components disappear when for example changing the color property from primary to accent.
It was confirmed to be reproducable on discord (see "Additional context")

System

System:
    OS: Windows 10 10.0.22621
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
  Binaries:
    Node: 18.13.0 - C:\Program Files\nodejs\node.EXE
    npm: 9.4.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.1413.0), Chromium (111.0.1661.62)
  npmPackages:
    @storybook/addon-essentials: ^7.0.2 => 7.0.2 
    @storybook/addon-interactions: ^7.0.2 => 7.0.2 
    @storybook/addon-links: ^7.0.2 => 7.0.2 
    @storybook/angular: ^7.0.2 => 7.0.2 
    @storybook/blocks: ^7.0.2 => 7.0.2 
    @storybook/testing-library: ^0.1.0 => 0.1.0

Additional context

It was confirmed on discord to be a bug: https://discord.com/channels/486522875931656193/490770949910691862/1086798445563629720 but I haven't been able to get an update and don't know if there is already an issue submitted. I could only check that it was not solved in the latest release

@valentinpalkovic valentinpalkovic added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 5, 2023
@shilman
Copy link
Member

shilman commented Apr 5, 2023

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.0 containing PR #21944 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

@shilman
Copy link
Member

shilman commented Apr 12, 2023

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.3 containing PR #21944 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants