Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: About page broken in built Storybooks #21899

Closed
shilman opened this issue Apr 4, 2023 · 3 comments · Fixed by #21951
Closed

[Bug]: About page broken in built Storybooks #21899

shilman opened this issue Apr 4, 2023 · 3 comments · Fixed by #21951

Comments

@shilman
Copy link
Member

shilman commented Apr 4, 2023

Describe the bug

Navigating to the About page in built 7.0 Storybooks breaks the UI. E.g.

The page appears to be working local dev mode.

To Reproduce

No response

System

No response

Additional context

No response

@ndelangen
Copy link
Member

Odd, I've tried making a static build of the exact sandbox this issue references I can't reproduce locally.

Debugging the code it seems related to the control panel, which dives into useArgs.
that hook throws with:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'type')

here:

const args = data.type === 'story' ? data.args : {};

I'll open a PR making this more fault tolerant, even though I can't reproduce it locally...

@shilman
Copy link
Member Author

shilman commented Apr 11, 2023

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.1 containing PR #21951 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@shilman
Copy link
Member Author

shilman commented Apr 12, 2023

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.3 containing PR #21951 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants