Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Module not found: Error: Can't resolve 'uuid-browser/v4' #21916

Closed
KahlaniOthman opened this issue Apr 4, 2023 · 23 comments · Fixed by #22037
Closed

[Bug]: Module not found: Error: Can't resolve 'uuid-browser/v4' #21916

KahlaniOthman opened this issue Apr 4, 2023 · 23 comments · Fixed by #22037

Comments

@KahlaniOthman
Copy link

KahlaniOthman commented Apr 4, 2023

Describe the bug

BREAKING CHANGE: The request 'uuid-browser/v4' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.

To Reproduce

upgrade storybook to 7.0.2 version

System

Environment Info:

  System:
    OS: macOS 13.2.1
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 18.13.0 - ~/.nvm/versions/node/v18.13.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v18.13.0/bin/yarn
    npm: 8.19.3 - ~/.nvm/versions/node/v18.13.0/bin/npm
  Browsers:
    Chrome: 111.0.5563.146
    Safari: 16.3
  npmPackages:
    @storybook/addon-actions: ^7.0.2 => 7.0.2 
    @storybook/addon-essentials: ^7.0.2 => 7.0.2 
    @storybook/addon-interactions: ^7.0.2 => 7.0.2 
    @storybook/addon-links: ^7.0.2 => 7.0.2 
    @storybook/addon-mdx-gfm: ^7.0.2 => 7.0.2 
    @storybook/cli: ^7.0.2 => 7.0.2 
    @storybook/react: ^7.0.2 => 7.0.2 
    @storybook/react-webpack5: ^7.0.0 => 7.0.2 
    @storybook/testing-library: ^0.1.0 => 0.1.0 

Additional context

No response

@cs1193
Copy link

cs1193 commented Apr 9, 2023

+1 seeing this issue on upgrade.

6.5.14 to 7.0.2 - manual upgrade, didn't use npx storybook@next automigrate

Screenshot 2023-04-09 at 6 23 58 PM

misino pushed a commit to misino/storybook that referenced this issue Apr 11, 2023
The library uuid-browser doesn't support esm, so the start with webpack fails.
misino pushed a commit to misino/storybook that referenced this issue Apr 11, 2023
The library uuid-browser doesn't support esm, so the start with webpack fails.
@tranvansang
Copy link

FYI

image

@annagel
Copy link

annagel commented Apr 13, 2023

issue happens also in "@storybook/addon-actions": "^7.0.4"
Screenshot 2023-04-13 at 14 06 35

@mido008
Copy link

mido008 commented Apr 14, 2023

any update to fix this issue?
i have the same problem when i add the addon "@storybook/addon-actions"

@KahlaniOthman
Copy link
Author

Hello,

I think, we just need to wait this pull request to be approved: #22037.
this pull will fix the issue

I hope so.

@KaiHotz
Copy link

KaiHotz commented Apr 14, 2023 via email

@KaiHotz
Copy link

KaiHotz commented Apr 16, 2023

@shilman can you please have a look at this and the corresponding PR #22037
so this can get approved and solved ?

This issue is still happening on version 7.0.5 and probably blocking a lot of people.

@SinimaWath
Copy link

Up. The same problem, tried to update to 7.0.5

@tommyblue
Copy link

tommyblue commented Apr 18, 2023

same here with 7.0.6 🙏🏼
is there any temporary workaround?

@zuritale
Copy link

I'd like to know if there is a temporary workaround for this, or a last stable version before 7.0.5

@KaiHotz
Copy link

KaiHotz commented Apr 19, 2023

@valentinpalkovic @shilman
Hi, this is still an issue on v7.0.6.
what would be the ETA to get this PR #22037 released ?

@shilman
Copy link
Member

shilman commented Apr 19, 2023

@KaiHotz if i merge the PR and publish a prerelease would you be able to test it?

@jakubwolny
Copy link

I volunteer as tester, can do this asap

@KaiHotz
Copy link

KaiHotz commented Apr 19, 2023

@shilman yes i can test this on a published prerelease

@tommyblue
Copy link

I can test too

jtbandes added a commit to foxglove/studio that referenced this issue Apr 19, 2023
**User-Facing Changes**
None

**Description**
Depends on #5776 
Resolves FG-2861
Includes a temporary patch to work around
storybookjs/storybook#21916
@usrrname
Copy link
Contributor

usrrname commented Apr 22, 2023

Can also confirm it's happening in v. 7.0.6. I can test too!

Environment Info:

  System:
    OS: macOS 13.3
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Binaries:
    Node: 16.17.1 - ~/.nvm/versions/node/v16.17.1/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 8.15.0 - ~/.nvm/versions/node/v16.17.1/bin/npm
  Browsers:
    Chrome: 112.0.5615.137
    Safari: 16.4
  npmPackages:
    @storybook/addon-a11y: ^7.0.6 => 7.0.6 
    @storybook/addon-actions: ~7.0.6 => 7.0.6 
    @storybook/addon-backgrounds: ^7.0.6 => 7.0.6 
    @storybook/addon-controls: ^7.0.6 => 7.0.6 
    @storybook/addon-docs: ^7.0.6 => 7.0.6 
    @storybook/addon-essentials: ^7.0.6 => 7.0.6 
    @storybook/addon-highlight: ^7.0.6 => 7.0.6 
    @storybook/addon-interactions: ~7.0.6 => 7.0.6 
    @storybook/addon-links: ^7.0.6 => 7.0.6 
    @storybook/cli: ^7.0.6 => 7.0.6 
    @storybook/csf: 0.1.0 => 0.1.0 
    @storybook/html: ~7.0.6 => 7.0.6 
    @storybook/html-webpack5: ~7.0.6 => 7.0.6 
    @storybook/manager-webpack5: ~6.5.16 => 6.5.16 
    @storybook/mdx2-csf: ^1.0.0 => 1.0.0 
    @storybook/theming: ^7.0.6 => 7.0.6 
    @storybook/types: ~7.0.6 => 7.0.6 
    ```

@shilman
Copy link
Member

shilman commented Apr 24, 2023

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.8 containing PR #22037 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@KaiHotz
Copy link

KaiHotz commented Apr 24, 2023

@shilman tested on v7.1.0-alpha.8 and all looks good, the issue is resolved.

@shilman
Copy link
Member

shilman commented Apr 24, 2023

@KaiHotz thanks for letting me know! Will release the patch to 7.0.x today

@shilman
Copy link
Member

shilman commented Apr 24, 2023

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.7 containing PR #22037 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

@KahlaniOthman
Copy link
Author

Thank you!

@usrrname
Copy link
Contributor

I too, notice the issue is now gone from my demo

@KaiHotz
Copy link

KaiHotz commented Apr 24, 2023

@shilman thank your for the quick response, i also can confirm that the issue is resolved on v7.0.7
@misino thank you for the PR and fixing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.