Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook init: Could not find the framework (abc) or renderer (xyz) package #22349

Closed
Tracked by #22243
yannbf opened this issue May 2, 2023 · 5 comments · Fixed by #22492
Closed
Tracked by #22243

storybook init: Could not find the framework (abc) or renderer (xyz) package #22349

yannbf opened this issue May 2, 2023 · 5 comments · Fixed by #22492
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented May 2, 2023

Error location: getFrameworkDetails.

Suggested work:

This error seems to be connected to users trying to initialize Storybook with community packages or packages we don't support anymore:

  • Could not find the framework (undefined) or renderer (storybook-solidjs) package
  • Could not find the framework (@storybook/marionette-webpack5) or renderer (@storybook/marionette)
  • Could not find the framework (@storybook/marko-webpack5) or renderer (@storybook/marko) package

We should do one of more of the following options:

  • Go through the baseGenerator file and clean it up by removing unsupported projects e.g. marko, mithrill, riot, aurelia, marionette, and rax.
  • Investigate and fix the storybook-solidjs scenario, which seems to happen quite often (probably because a single package is both a framework and a renderer, different than other packages)
@valentinpalkovic
Copy link
Contributor

Go through the baseGenerator file and clean it up by removing unsupported projects e.g. marko, mithrill, riot, aurelia, marionette, and rax.

@yannbf Which projects are unsupported? Is this a full list? Unsupported in which sense? I don't understand this sentence.

@yannbf
Copy link
Member Author

yannbf commented May 9, 2023

These are all authentic errors for the packages I mentioned:

Error: Could not find the framework (@storybook/rax-webpack5) or renderer (@storybook/rax) package
Error: Could not find the framework (@storybook/mithril-webpack5) or renderer (@storybook/mithril) package
Error: Could not find the framework (@storybook/marko-webpack5) or renderer (@storybook/marko) package
Error: Could not find the framework (@storybook/riot-webpack5) or renderer (@storybook/riot) package
Error: Could not find the framework (@storybook/aurelia-webpack5) or renderer (@storybook/aurelia) package
Error: Could not find the framework (@storybook/marionette-webpack5) or renderer (@storybook/marionette) package

mithrill, riot, aurelia, marionette, and rax were moved to be external community packages, and have since gotten stale/unmaintained (since version 6.2.9).

marko is the only package which actually was worked on but still does not support Storybook 7

@yannbf
Copy link
Member Author

yannbf commented May 9, 2023

We should:

  1. Clear the unused packages
  2. Either: Add SOLID as Vite by default or try to fix the issue by detecting Vite/Webpack from package.json as a fallback mechanism. If multiple are detected (e.g. monorepo), then prompt the user to select which one they'd like.

@shilman
Copy link
Member

shilman commented May 12, 2023

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.17 containing PR #22492 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

@shilman
Copy link
Member

shilman commented May 12, 2023

Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.11 containing PR #22492 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants