storybook init: Cannot destructure property 'root' of 'angularJSON.getProjectSettingsByName(...)' as it is undefined

[yannbf]

Error location: angular generator

Suggested work:

This is a bug in the way the angular.json file is parsed when initializing Storybook. Could be related to different formats present in different angular versions, or really just lack of better error handling. We should investigate it and fix it. Additionally, we should investigate the feedback from this comment and take into account when improving the error message (or maybe adding an FAQ entry to the docs website).

[valentinpalkovic]

I need a reproduction, otherwise, I don't know how to tackle this issue.

[yannbf]

Finding as part of this investigation: We should improve the handling here, as it sends null errors:
https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/generators/ANGULAR/index.ts#L34

[yannbf]

Finding: it's likely that this line of code receives undefined as this.projects[projectName] does not exist:
https://github.com/storybookjs/storybook/blob/next/code/lib/cli/src/generators/ANGULAR/index.ts#L41

[valentinpalkovic]

@yannbf I think you wanted to take this ticket over. Or was it another which we talked about yesterday?

[yannbf]

@valentinpalkovic you could take it if you'd like, especially if you know more about angular.json formats over angular versions!

[shilman]

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.13 containing PR #22663 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade

[shilman]

Yo-ho-ho!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.21 containing PR #22663 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future