Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Stories are not sorted by their exports when Webpack is v5.76.0 #22804

Closed
dkilgore-eightfold opened this issue May 25, 2023 · 5 comments
Closed

Comments

@dkilgore-eightfold
Copy link

Describe the bug

Upgrade from Webpack 5.64.4 to 5.76.0 causes stories to be sorted alphabetically, rather than by order exported.

To Reproduce

Repro branch via Dependabot PR --> EightfoldAI/octuple#564

  • Launch Terminal or CMD
  • Ensure you're using Node 16.14.2
  • Clone the PR branch
  • run yarn, and yarn storybook
  • Visit localhost port 2022

System

No response

Additional context

No response

@dkilgore-eightfold
Copy link
Author

@tmeasday Repro above, logged from #15574 (comment).

@tmeasday
Copy link
Member

@dkilgore-eightfold this project is on 6.5 so I would encourage you to try it out on 7.0, where the babel handling has changed quite a bit.

The issue comes from the lack of babel-plugin-named-exports-order. When I run yarn storybook --debug-webpack in the project I don't see that babel plugin which I would have expected.

@dkilgore-eightfold
Copy link
Author

@tmeasday I'll add this babel dep and push an update to this dependabot PR branch.

@dkilgore-eightfold
Copy link
Author

@tmeasday I've updated the Dependabot PR using the recommended exports plugin. Works a treat.

@shilman
Copy link
Member

shilman commented Jun 23, 2023

Glad to hear you got it sorted! 🎉 Closing this for now. Please let me know if there's more to be done.

@shilman shilman closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants