Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Main section disappears when navigating to addon tab #25322

Closed
rbardini opened this issue Dec 26, 2023 · 1 comment · Fixed by #25792
Closed

[Bug]: Main section disappears when navigating to addon tab #25322

rbardini opened this issue Dec 26, 2023 · 1 comment · Fixed by #25792
Assignees
Milestone

Comments

@rbardini
Copy link
Contributor

Describe the bug

While upgrading from Storybook 7.0 to 7.6, I noticed that the main section gets hidden when navigating to an addon tab. (Playroom in this case)

Manually removing the hidden attribute from the wrapping <div> in browser devtools fixes the issue, i.e. the addon matches the route and renders correctly, but Storybook hides it.

Interestingly, it doesn't seem to affect docs pages. Possibly related to #23292.

To Reproduce

Open the following deploy preview from rbardini/storybook-addon-playroom#54, navigate to stories and click the Playroom tab:

https://deploy-preview-54--storybook-addon-playroom.netlify.app/


I've also reproduced it in storybookjs/addon-kit after bumping Storybook dependencies to their latest versions:

git clone git@github.com:storybookjs/addon-kit.git && cd addon-kit
npx storybook@latest upgrade
npm start

Demo

System

System:
  OS: macOS 14.2.1
  CPU: (10) arm64 Apple M1 Pro
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 21.5.0 - /opt/homebrew/bin/node
  npm: 10.2.5 - /opt/homebrew/bin/npm <----- active
Browsers:
  Chrome: 120.0.6099.129
  Safari: 17.2.1
npmPackages:
  @storybook/react: ^7.0.0 => 7.6.6 
  @storybook/react-vite: ^7.0.0 => 7.6.6 
  storybook: ^7.0.0 => 7.6.6

Additional context

No response

@ndelangen
Copy link
Member

Hmm, yeah that looks quite serious, I will have to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants