We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
viteConfigPath is in the wrong place according to types.
viteConfigPath
https://stackblitz.com/edit/github-sgzxbx?file=.storybook%2Fmain.ts
Storybook Environment Info: System: OS: macOS 14.4.1 CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz Shell: 5.9 - /bin/zsh Binaries: Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.0/bin/yarn <----- active npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm pnpm: 8.9.2 - /usr/local/bin/pnpm Browsers: Chrome: 124.0.6367.62 Edge: 124.0.2478.51 Safari: 17.4.1 npmPackages: @storybook/addon-actions: 8.0.9 => 8.0.9 @storybook/addon-essentials: 8.0.9 => 8.0.9 @storybook/addon-interactions: 8.0.9 => 8.0.9 @storybook/addon-links: 8.0.9 => 8.0.9 @storybook/react: 8.0.9 => 8.0.9 @storybook/react-vite: 8.0.9 => 8.0.9 @storybook/test: ^8.0.9 => 8.0.9 eslint-plugin-storybook: 0.8.0 => 0.8.0 msw-storybook-addon: 2.0.0 => 2.0.0 storybook: 8.0.9 => 8.0.9 storybook-dark-mode: 4.0.1 => 4.0.1
import type { StorybookConfig } from '@storybook/react-vite'; const config: StorybookConfig = { ... framework: { name: '@storybook/react-vite', options: { viteConfigPath: '../configs/vite.storybook.config.ts', // <- Correct type }, }, };
According to https://storybook.js.org/docs/builders/vite#override-the-default-configuration, this is right
export default { stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|mjs|ts|tsx)'], core: { builder: { name: '@storybook/builder-vite', options: { viteConfigPath: '../customVite.config.js', }, }, }, };
storybook/docs/snippets/common/main-config-builder-custom-config.js.mdx
Line 10 in 7b2ddea
however, the types suggest:
framework: { name: '@storybook/react-vite', options: { builder: { viteConfigPath: '../configs/vite.storybook.config.ts', // <- which is incorrect } }, },
Realted links:
storybook/code/builders/builder-vite/README.md
Lines 65 to 85 in 7b2ddea
storybook/code/builders/builder-vite/src/types.ts
Lines 20 to 25 in 7b2ddea
storybook/code/frameworks/react-vite/src/types.ts
Lines 11 to 30 in 7b2ddea
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
viteConfigPath
is in the wrong place according to types.To Reproduce
https://stackblitz.com/edit/github-sgzxbx?file=.storybook%2Fmain.ts
System
Additional context
According to https://storybook.js.org/docs/builders/vite#override-the-default-configuration, this is right
storybook/docs/snippets/common/main-config-builder-custom-config.js.mdx
Line 10 in 7b2ddea
however, the types suggest:
Realted links:
storybook/code/builders/builder-vite/README.md
Lines 65 to 85 in 7b2ddea
storybook/code/builders/builder-vite/src/types.ts
Lines 20 to 25 in 7b2ddea
storybook/code/frameworks/react-vite/src/types.ts
Lines 11 to 30 in 7b2ddea
The text was updated successfully, but these errors were encountered: