Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook React Native Unable hide UI by getStorybookUI param #4953

Closed
mowbell opened this issue Dec 7, 2018 · 3 comments
Closed

Storybook React Native Unable hide UI by getStorybookUI param #4953

mowbell opened this issue Dec 7, 2018 · 3 comments

Comments

@mowbell
Copy link

mowbell commented Dec 7, 2018

Describe the bug
in Docs getStorybookUI has a param to hide UI isUIHidden.

But in source code in preview/index.js it expect param with name isUIOpen instead of isUIHidden
The correct param name is isUIHidden that is expected by preview/OnDeviceUI/index.js

To Reproduce
Try writing

const StorybookUIRoot = getStorybookUI({ port: 7007, onDeviceUI: true, isUIOpen: false });
const StorybookUIRoot = getStorybookUI({ port: 7007, onDeviceUI: true, isUIHidden: false });

None is working

Expected behavior
Expected menu hidden on storybook start

System:

  • OS: MacOS
  • Device: Simulator Iphone 7
  • Framework: React Native
  • Version: ^4.0.11
@Gongreg
Copy link
Member

Gongreg commented Dec 18, 2018

Hey @mowbell, I will look into this tomorrow.

@shilman
Copy link
Member

shilman commented Dec 21, 2018

w00t!! I just released https://github.com/storybooks/storybook/releases/tag/v4.2.0-alpha.6 containing PR #5067 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

@shilman
Copy link
Member

shilman commented Jan 24, 2019

Yippee!! I just released https://github.com/storybooks/storybook/releases/tag/v4.1.11 containing PR #5067 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants