Make absolute path for dlls relative

[cmwhiting]

The dlls are loaded as dlls: ['/sb_dll/storybook_ui_dll.js'] in @storybook/core/src/server/manager/manager-webpack.config.js, but if you're serving static files outside of the root directory, this will fail. This should hopefully be something relative, like dlls: ['sb_dll/storybook_ui_dll.js'] or dlls: ['./sb_dll/storybook_ui_dll.js']

Ex: I have a node server stood up on localhost:4000, serving from ./public. I change my storybook output directory to ./public/storybook. The files are created, and loading localhost:4000/storybook serves the page, but requests localhost:4000/sb_dll/storybook_ui_dll.js, which doesn't exist. With relative pathing, it would request as localhost:4000/storybook/sb_dll/storybook_ui_dll.js, which would resolve correctly.

[ozio]

Same problem. We have a several environments and want to put storybooks to each of them as a subfolder, but we can't because of that absolute path. Had tried to change publicPath in webpack config, but it works only for paths in iframe.html.

[gpincheiraa]

Same problem here!

[unindented]

I'm also affected by this. In my case, I'm publishing to GitHub Pages, which are always https://<user>.github.io/<project>/, so storybook_ui_dll.js can never be found.

[Pluzu]

Same problem here

[dangerdespain]

+1, I'm affected by this as well

[dangerdespain]

For anyone else running across this, here's a build command that should fix this temporarily

{
  "scripts" : {
    "build-storybook": "rm -rf storybook-static && build-storybook && sed -i -e 's/\\\/sb_dll/sb_dll/g' storybook-static/index.html"
  }
}

[ndelangen]

I'm going to fix this ASAP

[shilman]

Boo-yah!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-alpha.1 containing PR #5238 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

[shilman]

Mind giving this a try and letting me know if it works for you? If so, I'll cherry-pick this back to master and do a patch release. Thanks!

@cmwhiting @mysticatea @alex996 @ozio @asychev @Chariyski @baohouse @benjablanko @gpincheiraa @Stevo14850 @unindented @liss-mouse @vio @Pluzu @lauriejones @yhuard @johnhunter @heavenshell @dkimura @dangerdespain @ndelangen

[ozio]

Already. Can confirm that new path is relative: ./sb_dll/storybook_ui_dll.js instead of /sb_dll/storybook_ui_dll.js.

[shilman]

Whoopee!! I just released https://github.com/storybooks/storybook/releases/tag/v4.1.9 containing PR #5238 that references this issue. Upgrade today to try it out!