Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addon-ondevice-knobs does not support React Native >= 0.56 (requires dependency upgrade) #5545

Closed
erikthedeveloper opened this issue Feb 11, 2019 · 3 comments

Comments

@erikthedeveloper
Copy link

Describe the bug

@storybook/addon-ondevice-knobs does not support React Native >= 0.56 due to its dependency on react-native-modal-datetime-picker. My Storybook in React Native is working great until attempting to introduce knobs. Attempting to use knobs results in this error:

Error: We don't know what to do with this node type. We were previously a Statement but we can't fit in here?

https://github.com/storybooks/storybook/blob/d9cd83c2d5e1d160effdc6f51d1dd19a279b5028/addons/ondevice-knobs/package.json#L28

This has been fixed/release in https://github.com/mmazzarolo/react-native-modal-datetime-picker/releases/tag/v6.0.0 see merged PR mmazzarolo/react-native-modal-datetime-picker#171 and original reported issue react-native-modal/react-native-modal#178

Upgrading react-native-modal-datetime-picker to 6.0.0 should fix the problem.

To Reproduce
Steps to reproduce the behavior:

  1. Attempt using addon-knobs with React Native >= 0.56. Follow instructions at:
    1. https://github.com/storybooks/storybook/tree/master/addons/knobs
    2. https://github.com/storybooks/storybook/tree/next/addons/ondevice-knobs

Expected behavior
App should build/run. Knobs should work.

Screenshots:
image

System:

  • Framework: React Native
  • Addons: knobs, ondevice-knobs
  • Version: 4.1.11 (through to 5.x)
@Gongreg
Copy link
Member

Gongreg commented Feb 14, 2019

Hey @erikthedeveloper, there is #4425 opened some time ago. Did you try out version 6 and it helped? It didn't break anything else? We could just update the dependency then.

@stale
Copy link

stale bot commented Mar 7, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 7, 2019
@shilman
Copy link
Member

shilman commented Mar 8, 2019

Released a fix at https://github.com/storybooks/storybook/releases/tag/v4.1.14

Please give it a try! Closing this for now.

@shilman shilman closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants