Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show update available every time you start storybook #5683

Closed
tjbenton opened this issue Feb 20, 2019 · 3 comments
Closed

Don't show update available every time you start storybook #5683

tjbenton opened this issue Feb 20, 2019 · 3 comments
Assignees

Comments

@tjbenton
Copy link

There was an update released 2 days ago to @storybook/vue and now every time I run start-storybook it shows me a huge message telling me that there's a new version available. While this is a nice feature to let users know a new version is available it's also incredibly annoying to see every single time I start storybook. As every one knows when working on a large project with several people it takes time to update packages and that means it doesn't happen instantly.

To Reproduce
Steps to reproduce the behavior:

  1. install @storybook/vue
  2. run start-storybook
  3. see huge message telling me to update

Expected behavior
Instead of showing the update message every time it's run it should show you there's an update once a week at max, anything more than that and it get's very annoying very quickly. This is the behavior I would expect regardless of --quiet being passed in or not

Screenshots
screen shot 2019-02-20 at 9 56 41 am

System:

  • OS: MacOS
  • Framework: vue
  • Version: 4.1.11
@shilman
Copy link
Member

shilman commented Feb 20, 2019

@tjbenton My bad! We've updated the way release checks work in v5 and I forgot that this was already being used in v4. Will fix in v4.1.13!

@shilman
Copy link
Member

shilman commented Feb 21, 2019

Yowza!! I just released https://github.com/storybooks/storybook/releases/tag/v4.1.13 containing PR #5699 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 21, 2019
@shilman
Copy link
Member

shilman commented Feb 21, 2019

w00t!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.4 containing PR #5699 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants