New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs only build not working after upgrading to 5.2.1 #8148
Comments
Upgraded storybook design system to 5.2.1 and not seeing this problem https://github.com/storybookjs/design-system Can you make a repro? |
Hmm, I will try to set it up again fresh and see what happens. Side question, what is the best way to accomplish this. I want to have a header of docs written in MDX above my stories, then have my stories that are written in CSF loaded, then a footer of more docs at the bottom. Is this possible? |
This is possible right now, but we're going to make it easier in 5.3. Rather than working around the current structure, I'll try to release the better way of doing it in 5.3-alpha this coming week. |
@jgodi we had this problem a lot on Chrome. I hope this helps a little. |
Thats awesome, let me know when that is available. I will definitely test it out right away. |
@elevatebart Tried this and even tried a different browser and still I get canvas and docs. I will wait until the new 5.3-alpha and try again when I redo our stories. Thanks! |
@jgodi releasing a 5.3-alpha but have not made the fix yet. will try to get to it in the next day or two! |
Tried everything today to get the docs only build working. It builds with Canvas/Docs tabs and defaults to the Docs tab, but before we had only docs mode deployed. Is this still a thing? |
@jgodi I'm not sure I understand your question. As far as I know, |
If you look at the screenshot above, you see the Canvas tab and Docs tab. This was build with us being on version 5.2.1 and using When we were on 5.2.0-alpha.36 and we built using Is there a way to go back to having no tabs displayed and be in only docs mode? |
@jgodi Do you have a reproduction? It's working in our repos, so I'd need to take a look at a broken repo to debug what's going on, and I don't have one. |
@shilman Repro here in this repo: https://github.com/jgodi/storybook-test Even tried with v5.3.0-alpha.2 of @storybook/addon-docs |
@jgodi remove the showPanel option: https://github.com/jgodi/storybook-test/blob/master/.storybook/config.js#L8 See also: #8063 |
Ah, thanks. I searched and searched before opening the issue too. Glad it was an easy fix. Thank you for looking into it and helping out. |
@shilman any update on this part? Would love to try this out. |
@jgodi Not yet, I'll try to get something out this week! |
I'm still getting this issue on 6.3.2. |
@tuncaulubilge do you have a reproduction repo you can share? Or you can create one by running |
@shilman I was able to reproduce it with a fresh CRA app and Just run |
@shilman Sorry to be the guy that keeps asking "Are we there yet?", but is there a roadmap on this one. Currently there are no workarounds on this as far as I'm aware, so we are trying to assess whether to wait for Storybook Docs, or build a regular storybook until the issue is fixed. |
I'm seeing this on the latest version of Storybook. demo.mov |
Maybe this can be closed for #15933 |
Describe the bug
Building with
--docs
no longer just builds the docs tab. It has the canvas tab as well.To Reproduce
Steps to reproduce the behavior:
--docs
Expected behavior
No tabs, just defaulting to the docs
Screenshots
System:
The text was updated successfully, but these errors were encountered: