Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using latest create-react-app #8223

Closed
balazsorban44 opened this issue Sep 29, 2019 · 9 comments
Closed

Error when using latest create-react-app #8223

balazsorban44 opened this issue Sep 29, 2019 · 9 comments
Labels
bug cra Prioritize create-react-app compatibility inactive

Comments

@balazsorban44
Copy link

balazsorban44 commented Sep 29, 2019

Describe the bug
I recently updated @storybook/react and react-scripts, and now I cannot start storybook.
With @storybook/react@5.2.1 and react-scripts@3.1.x, I get the error presented on the screenshot. Changing back to react-scripts@3.0.1 though works fine.

To Reproduce
Steps to reproduce the behavior:

  1. Install @storybook/react@5.2.1 and react-scripts@3.1.x,
  2. Create a story
  3. Start storybook
  4. See error

Expected behavior
Should not crash.

Screenshots
If applicable, add screenshots to help explain your problem.
image

System:

  System:
    OS: Linux 5.0 Ubuntu 19.04 (Disco Dingo)
    CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz
  Binaries:
    Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
    Yarn: 1.17.3 - ~/.yarn/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
  Browsers:
    Chrome: 77.0.3865.90
    Firefox: 69.0.1
  npmPackages:
    @storybook/react: ^5.2.1 => 5.2.1 

Additional context
I am uncertain if this is an issue with storybook or CRA.

@marcel0ll
Copy link

marcel0ll commented Sep 29, 2019

Having the same issue.
As stated, downgrading react-scripts to 3.0.1 works

@shilman shilman added bug cra Prioritize create-react-app compatibility labels Sep 30, 2019
@mrmckeb
Copy link
Member

mrmckeb commented Sep 30, 2019

Hi @0tho, have you tried (while on the newer react-scripts) removing your node_modules and lockfile, and reinstalling?

@calumgunn
Copy link

calumgunn commented Sep 30, 2019

Hi @mrmckeb - I'm having the same issue, and a reinstall didn't fix things.

My error is different, however:

Uncaught (in promise) TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at vendors~main.cff839a2a50bbfd2c813.bundle.js:8101
    at memoizerific (vendors~main.cff839a2a50bbfd2c813.bundle.js:67932)
    ...

Do let me know if this feels separate to this issue and I'll add a new one!

@mrmckeb
Copy link
Member

mrmckeb commented Sep 30, 2019

Are you able to share that repo with me @calumgunn?

@calumgunn
Copy link

@mrmckeb Sadly not as it's in a private repo... I'll try to find time to create a minimal reproduction today.

@marcel0ll
Copy link

@mrmckeb deleting node_modules, lockfile and reinstalling didn't solve the problem. (tried both npm and yarn)

I also can't share my main repo, but I will try to create a minimum project later.

I believe this error could be related to this

@mrmckeb
Copy link
Member

mrmckeb commented Oct 1, 2019

Thanks, reproductions are very valuable - and I understand that you can't always share a project.

@0tho, if you're issue is related to the issue you linked to, that has been resolved... I'll ask for a patch release.

facebook/create-react-app#7754

@marcel0ll
Copy link

@mrmckeb updated to react-scripts@3.1.2 and for me it has fixed the problems.

@stale
Copy link

stale bot commented Oct 22, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 22, 2019
@shilman shilman closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cra Prioritize create-react-app compatibility inactive
Projects
None yet
Development

No branches or pull requests

5 participants