Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production builds on storybook can fail. #9026

Closed
pllee opened this issue Dec 2, 2019 · 3 comments
Closed

Production builds on storybook can fail. #9026

pllee opened this issue Dec 2, 2019 · 3 comments

Comments

@pllee
Copy link

pllee commented Dec 2, 2019

Describe the bug
@storybook/core depends on "html-webpack-plugin": "^4.0.0-beta.2", which has an issue when using production mode
To Reproduce
build-storybook -s
I have not tested this on a fresh storybook install but my set up fails.

Screenshots

info => Loading manager config..
info => Loading presets
info => Compiling manager..
ERR! => Failed to build the manager
ERR!   Error: Cannot find module 'html-minifier'
ERR!
ERR!   - module.js:11 require
ERR!     internal/module.js:11:18
ERR!
ERR!   - index.js:445 HtmlWebpackPlugin.postProcessHtml
ERR!     [name]/[html-webpack-plugin]/index.js:445:9
ERR!
ERR!   - index.js:274 Promise.all.then.then
ERR!     [name]/[html-webpack-plugin]/index.js:274:25
@pllee pllee changed the title Production builds on storybook fail. Production builds on storybook can fail. Dec 2, 2019
@stale stale bot added the inactive label Dec 24, 2019
@shilman
Copy link
Member

shilman commented Dec 24, 2019

@ndelangen can we upgrade this?

@stale stale bot removed the inactive label Dec 24, 2019
@storybookjs storybookjs deleted a comment from stale bot Jan 9, 2020
ndelangen added a commit that referenced this issue Jan 9, 2020
@stale stale bot added the inactive label Jan 30, 2020
@storybookjs storybookjs deleted a comment from stale bot Jan 30, 2020
@stale stale bot removed the inactive label Jan 30, 2020
@stale
Copy link

stale bot commented Feb 20, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 20, 2020
@stale
Copy link

stale bot commented Mar 21, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants