Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config test for register add ons #9343

Closed
atanasster opened this issue Jan 7, 2020 · 3 comments
Closed

New config test for register add ons #9343

atanasster opened this issue Jan 7, 2020 · 3 comments
Assignees

Comments

@atanasster
Copy link
Member

atanasster commented Jan 7, 2020

Describe the bug

using a register file in the add ons section generates a console error:

ERR! Addon value should end in /register OR it should be a valid preset https://storybook.js.org/docs/presets/introduction/
ERR! /Users/atanasster/storybook-addon-deps/dist/register.js

To Reproduce

module.exports = {
  addons: [require.resolve('./register')],
}  
@shilman
Copy link
Member

shilman commented Jan 8, 2020

Hurrah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-rc.12 containing PR #9347 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jan 8, 2020
@RuneKR
Copy link

RuneKR commented Jan 14, 2020

Hi. The solution does not work on a MacBook. Regex fails for absolute paths such as /User/Rune/some/nested/@at/here/register.js

@shilman
Copy link
Member

shilman commented Jan 16, 2020

Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.4 containing PR #9485 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants