Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Race condition in yarn run createDlls #9707

Closed
shilman opened this issue Feb 2, 2020 · 3 comments
Closed

Build: Race condition in yarn run createDlls #9707

shilman opened this issue Feb 2, 2020 · 3 comments
Assignees
Labels
maintenance User-facing maintenance tasks
Projects

Comments

@shilman
Copy link
Member

shilman commented Feb 2, 2020

When i run yarn bootstrap --reset --core:

storybook info bootstrap Generate DLL (dll)
storybook info bootstrap dll
lerna notice cli v3.19.0
lerna notice filter including "@storybook/ui"
lerna info filter [ '@storybook/ui' ]
lerna info Executing command in 1 package: "yarn run createDlls"
lerna ERR! yarn run createDlls exited 1 in '@storybook/ui'
lerna ERR! yarn run createDlls stdout:
$ node -r esm ./scripts/createDlls.js
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run createDlls stderr:
/Users/shilman/projects/baseline/storybook/lib/ui/scripts/createDlls.js:1
import path from 'path';
SyntaxError: Unexpected identifier
    at new Script (vm.js:83:7)
error Command failed with exit code 1.
lerna ERR! yarn run createDlls exited 1 in '@storybook/ui'
error Command failed with exit code 1.

however, when i subsequently run yarn bootstrap --core it succeeds.
this is a small thing. but it's problem, because it adds an extra step to my release process, and i release all the time. it's my first time to encounter this, and i'm seeing it on both next and master.

Note: I just upgraded to yarn@1.21.1. I'm not sure if it's related.

@shilman shilman added the maintenance User-facing maintenance tasks label Feb 2, 2020
@lmaze
Copy link
Contributor

lmaze commented Feb 4, 2020

Same error with the yarn bootstrap --all command.

@shilman
Copy link
Member Author

shilman commented Feb 7, 2020

Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.7 containing PR #9770 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Feb 7, 2020
@shilman
Copy link
Member Author

shilman commented Feb 12, 2020

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.13 containing PR #9770 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
No open projects
Hotlist
Awaiting triage
Development

No branches or pull requests

3 participants