Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix docs.disable parameter on DocsPage #17256

Merged
merged 1 commit into from Jan 17, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 17, 2022

Issue: #16895

What I did

Filter out DocsPage stories that have docs.disable set to a truthy value

Self-merging @tmeasday

How to test

See official-storybook Docs stories

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch addon: docs labels Jan 17, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jan 17, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit eaddc6d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit 8747f9c into next Jan 17, 2022
@shilman shilman deleted the 16895-fix-docs-disable branch January 17, 2022 11:41
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 20, 2022
shilman added a commit that referenced this pull request Jan 20, 2022
Addon-docs: Fix `docs.disable` parameter on DocsPage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant